mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
bc78b19853
For reasons lost to history and not interesting enough to uncover, the “override” computation performed a check of the overriding declaration’s Objective-C selector against the potentially-overridden declaration’s Objective-C selector. This introduced a cycle dependency between the “is exposed to Objective-C” computation and the “overridden declarations” computation, because @objc is inherited from an overridden declaration. We’ll detect the same errors via other, existing diagnostics, so prune out the Objective-C selector checks from the override path.
40 lines
1.4 KiB
Swift
40 lines
1.4 KiB
Swift
// RUN: %target-typecheck-verify-swift -swift-version 4
|
|
//
|
|
// REQUIRES: objc_interop
|
|
|
|
class MixedKeywordsAndAttributes { // expected-note{{in declaration of 'MixedKeywordsAndAttributes'}}
|
|
// expected-error@+1 {{expected declaration}} expected-error@+1 {{consecutive declarations on a line must be separated by ';'}} {{11-11=;}}
|
|
override @objc func f1() {}
|
|
}
|
|
|
|
@objc class ObjCClass {}
|
|
struct SwiftStruct { }
|
|
|
|
class A {
|
|
@objc subscript (a: ObjCClass) -> ObjCClass {
|
|
get { return ObjCClass() } // expected-note{{subscript getter declared here}}
|
|
}
|
|
|
|
func bar() { } // expected-note{{add '@objc' to make this declaration overridable}}{{3-3=@objc }}
|
|
}
|
|
|
|
extension A {
|
|
func foo() { } // expected-note{{add '@objc' to make this declaration overridable}}{{3-3=@objc }}
|
|
func wibble(_: SwiftStruct) { } // expected-note{{overridden declaration is here}}
|
|
}
|
|
|
|
class B : A {
|
|
// Objective-C
|
|
@objc subscript (a: ObjCClass) -> AnyObject {
|
|
get { return self } // expected-error{{subscript getter with Objective-C selector 'objectForKeyedSubscript:' conflicts with subscript getter from superclass 'A'}}
|
|
}
|
|
|
|
override func foo() { } // expected-error{{overriding non-@objc declarations from extensions is not supported}}
|
|
|
|
override func wibble(_: SwiftStruct) { } // expected-error{{overriding declarations in extensions is not supported}}
|
|
}
|
|
|
|
extension B {
|
|
override func bar() { } // expected-error{{overriding non-@objc declarations from extensions is not supported}}
|
|
}
|