Andrew Trick 5983aae176 Fix AccessEnforcementReleaseSinking. Check for illegal cases. ...

In the included, test case, the optimization was sinking
releases past is_escaping_closure.

Rewrite the isBarrier logic to be conservative and define the
mayCheckRefCount property in SIL/InstructionUtils. Properties that may
need to be updated when SIL changes belong there.

Note that it is particularly bad behavior if the presence of access
markers in the code cause miscompiles unrelated to access enforcement.

Fixes <rdar://problem/45846920> TestFoundation, TestProcess, closure
argument passed as @noescape to Objective-C has escaped.

2018-11-06 13:52:03 -08:00

17 KiB

Raw Blame History

View Raw