mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
cd8d3adab0
Before the update to support the new syntax, the decl checker treated private and fileprivate members of objcImpl extensions as non-@objc by default. But SE-0436 specified that private and fileprivate members should be implicitly @objc unless opted out, so when support for the final syntax was added, this behavior was changed retroactively. Unfortunately, we’ve found that some early adopters depended on the old behavior. Restore some logic deleted by #73309 for early adopter syntax *only*, with a warning telling the developer to put `final` or `@nonobjc` on the declaration if they want to preserve the behavior after updating it. Also tweaks the ObjCImplementationChecker to ensure this logic will actually be run in time for it to suppress the “upgrade to @objc @implementation” warning, and corrects a couple of regressions arising from that change. Fixes rdar://135747897.
27 lines
1.3 KiB
Swift
27 lines
1.3 KiB
Swift
// RUN: %empty-directory(%t)
|
|
// RUN: %target-typecheck-verify-swift -target %target-stable-abi-triple -module-name main -I %S/Inputs %s
|
|
// RUN: %target-swift-frontend -emit-module -target %target-stable-abi-triple -module-name main -o %t -I %S/Inputs %s
|
|
// RUN: llvm-bcanalyzer %t/main.swiftmodule > %t/main.swiftmodule.txt
|
|
// RUN: %target-swift-ide-test -print-module -target %target-stable-abi-triple -module-to-print=main -I %t -source-filename=%s >%t/main.txt
|
|
// RUN: %FileCheck %s --input-file=%t/main.txt
|
|
|
|
// REQUIRES: objc_interop
|
|
|
|
import Foundation
|
|
import objc_implementation
|
|
|
|
// rdar://134730183 - ensure that errors reduced to warnings by early adopter
|
|
// syntax don't invalidate the @implementation attribute (and cause it to not
|
|
// be serialized)
|
|
|
|
// CHECK-LABEL: @_objcImplementation extension ObjCImpl
|
|
@_objcImplementation extension ObjCImpl {
|
|
// CHECK-DAG: func cannotBeObjCMethod(_ value: Int?)
|
|
private func cannotBeObjCMethod(_ value: Int?) {}
|
|
// expected-warning@-1 {{instance method 'cannotBeObjCMethod' will become implicitly '@objc' after adopting '@objc @implementation'; add 'final' to keep the current behavior}} {{3-3=final }}
|
|
// expected-note@-2 {{add '@objc' to expose this instance method to Objective-C}} {{3-3=@objc }}
|
|
|
|
// CHECK-DAG: @objc func goodMethod()
|
|
@objc public func goodMethod() {}
|
|
}
|