John McCall 976f1494f5 [NFC] Introduce DiagRef and use it throughout the parser ...

The goal is to have a lightweight way to pass an unapplied
diagnostic to general routines.  Constructing a Diagnostic
is quite expensive as something we're potentially doing in
hot paths, as opposed to just when we're actually emitting
the diagnostic.  This design allows the expense to be delayed
until we need it.

I've also optimized the Diagnostic constructor to avoid
copying arguments unnecessarily; this is a relatively small
expense, since arguments are POD, but there's really no good
reason not to do it.

2024-03-01 22:09:47 -05:00

15 KiB

Raw Blame History

View Raw