mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
It turns out the query to check the reference semantics of a type had the side effect of importing some functions/types. This could introduce circular reference errors with our queries. This PR removes this side effect from the query and updates the test files. Since we do the same work later on in another query, the main change is just the wording of the diagnostics (and we now can also infer immortal references based on the base types). This PR also reorders some operations, specifically now we mark base classes as imported before we attempt to import template arguments. After these changes it is possible to remove the last feature check for strict memory safe mode. We want to mark types as @unsafe in both language modes so we can diagnose redundant unsafe markers even when the feature is off.
6.2 KiB
6.2 KiB