Charles Kerr
64268a3a7f
feat: remove informed-consent dialogs ( #7920 )
2025-12-10 16:28:49 -06:00
Yat Ho
2ee411d222
ci: set ENABLE_TESTS to make-tests on alpine ( #7914 )
2025-12-10 11:48:48 -06:00
Charles Kerr
f73a259a4e
docs: add quark citation code comments ( #7912 )
2025-12-10 08:18:38 -06:00
Yat Ho
a8e20bf358
refactor: track active request timeout per peer per block ( #7899 )
2025-12-09 22:42:49 -06:00
Charles Kerr
bf48eadaeb
refactor: replace Settings class with Serializable ( #7877 )
...
* refactor: replace Settings class with Serializable
* Fields can now be declared as const static,
so we only have to build this list once per class
instead of once per iteration.
* Add typesafe single-property getters & setters.
* Split the converter registry into a generic standalone class.
* refactor: make Serializable::Field::getter private
refactor: make Serializable::Field::const_getter private
* docs: tweak code comments
* refactor: make Serializable::Field::Getter private
refactor: make Serializable::Field::ConstGetter private
refactor: make Serializable::Field::MemberStorage private
* chore: fix readability-identifier-naming clang-tidy warnings
* Update libtransmission/serializable.h
Co-authored-by: Yat Ho <lagoho7@gmail.com >
* Update libtransmission/serializable.h
Co-authored-by: Yat Ho <lagoho7@gmail.com >
* Update libtransmission/serializable.h
Co-authored-by: Yat Ho <lagoho7@gmail.com >
* fixup! Update libtransmission/serializable.h
---------
Co-authored-by: Yat Ho <lagoho7@gmail.com >
2025-12-09 22:09:49 -06:00
Charles Kerr
e671c0346c
feat: add tr_variant::Map methods ( #7910 )
...
* feat: add tr_variant::Map::contains()
* feat: add tr_variant::Map::replace_key()
* fixup! feat: add tr_variant::Map::replace_key()
fix readability-braces-around-statements
* fixup! feat: add tr_variant::Map::contains()
readability-container-contains
2025-12-09 21:16:59 -06:00
Charles Kerr
9f911d4d52
refactor: intern recently-active ( #7909 )
...
* refactor: intern recently-active
* fixup! refactor: intern recently-active
fix a couple of literals missed in rpcimpl.cc
2025-12-09 21:15:07 -06:00
Charles Kerr
64231c1076
refactor: extract-method is_valid_id() in rpcimpl ( #7907 )
2025-12-09 18:18:46 -06:00
Yat Ho
ca325e5c42
fix: add conversion from kebab-case to sleep_per_seconds_during_verify ( #7870 )
2025-12-09 18:12:51 -06:00
github-actions[bot]
4bf5c32a1f
chore: update generated transmission-web files ( #7863 )
...
Co-authored-by: ckerr <70381+ckerr@users.noreply.github.com >
2025-12-09 18:10:04 -06:00
Charles Kerr
a630787340
test: add rpc tests for legacy & jsonrpc free_space requests, responses ( #7905 )
2025-12-09 16:19:01 -06:00
Charles Kerr
fece4137c7
refactor: add tr_variant::unmanaged_string(tr_quark) ( #7906 )
...
* feat: add tr_variant::unmanaged_string(tr_quark)
* refactor: use tr_variant::unmanaged_string(tr_quark)
2025-12-09 14:58:15 -06:00
Yat Ho
20161fa044
fix: only shrink wishlist block span if previous piece is wanted ( #7900 )
2025-12-09 14:01:00 -06:00
Charles Kerr
0979bbcc3f
refactor: intern RPC method names ( #7892 )
...
* refactor: add quarks for the RPC method names
* update tr_quark_convert() to handle RPC method names
* refactor: use interned keys for RPC method names
* test: add torrentGetLegacy test
* refactor: use interned keys for RPC method names in tr-qt
* refactor: use interned keys for RPC method names in tr-remote
* refactor: use interned keys for RPC method names in tests
* refactor: use interned keys for RPC method names in tr-gtk
* chore: fix readability-identifier-naming regression
2025-12-09 11:48:09 -06:00
Yat Ho
095bad6568
fix: check if piece is wanted upon receiving block ( #7866 )
...
* fix: check if piece is wanted upon receiving block
* test: block_last_loc
2025-12-08 15:43:56 -06:00
Charles Kerr
33d6804a76
refactor: remove unused quarks ( #7883 )
...
* chore: remove two unused quarks
looks like these were never used?
* chore: remove unused quark TR_KEY_have
unused since May 2024 3677e7a5
* chore: remove unused quark TR_KEY_date
unused since Oct 2021 9200d972
* fix: remove unused codepath
2025-12-07 21:08:07 -06:00
Yat Ho
e034799f6f
perf: use iterator range insert in Wishlist::next ( #7890 )
2025-12-07 11:15:14 -06:00
Yat Ho
8dc5080dc7
fix: FTBFS in C++20 ( #7880 )
2025-12-06 01:31:55 -06:00
Charles Kerr
4bbc2e9c42
ci: use clang for alpine-musl build ( #7879 )
2025-12-05 18:26:35 -06:00
Charles Kerr
2cddbce459
chore: update package-lock.json ( #7878 )
...
resolve js-yaml CVE-2025-64718
This CVE does not affect Transmission users. We only use this package for running eslint checcks in CI.
2025-12-05 16:44:23 -06:00
Charles Kerr
c92b42de9c
chore: bump to 4.1.0-beta.4 ( #7869 )
...
* docs: add release notes for 4.1.0-beta.4
* chore: bump to Transmission 4.1.0-beta.3
4.1.0-beta.4
2025-12-03 17:04:08 -06:00
Yat Ho
9dd9aab902
build: bump clang tools to 20 ( #7573 )
...
* build: bump to clang-format-20
* build: bump to clang-tidy-20
* chore: revert edc59ba5d8
2025-12-01 23:18:02 -06:00
Yat Ho
05aef3e787
refactor: unify quarks and strings to snake_case ( #7108 )
...
* refactor: change `leftUntilDone` to `left_until_done`
* refactor: change `magnetLink` to `magnet_link`
* refactor: change `manualAnnounceTime` to `manual_announce_time`
* refactor: change `maxConnectedPeers` to `max_connected_peers`
* refactor: change `metadataPercentComplete` to `metadata_percent_complete`
* refactor: change `peersConnected` to `peers_connected`
* refactor: change `peersFrom` to `peers_from`
* refactor: change `peersGettingFromUs` to `peers_getting_from_us`
* refactor: change `peersSendingToUs` to `peers_sending_to_us`
* refactor: change `percentComplete` to `percent_complete`
* refactor: change `percentDone` to `percent_done`
* refactor: change `pieceCount` to `piece_count`
* refactor: use quark when possible
* refactor: change `pieceSize` to `piece_size`
* refactor: change `primary-mime-type` to `primary_mime_type`
* refactor: change `rateDownload` to `rate_download`
* refactor: change `rateUpload` to `rate_upload`
* refactor: change `recheckProgress` to `recheck_progress`
* refactor: change `secondsDownloading` to `seconds_downloading`
* refactor: change `secondsSeeding` to `seconds_seeding`
* refactor: change `sizeWhenDone` to `size_when_done`
* refactor: change `startDate` to `start_date`
* refactor: change `trackerStats` to `tracker_stats`
* refactor: change `totalSize` to `total_size`
* refactor: change `torrentFile` to `torrent_file`
* refactor: change `uploadedEver` to `uploaded_ever`
* refactor: change `uploadRatio` to `upload_ratio`
* refactor: change `webseedsSendingToUs` to `webseeds_sending_to_us`
* refactor: change `bytesCompleted` to `bytes_completed`
* refactor: change `clientName` to `client_name`
* refactor: change `clientIsChoked` to `client_is_choked`
* refactor: change `clientIsInterested` to `client_is_interested`
* refactor: change `flagStr` to `flag_str`
* refactor: change `isDownloadingFrom` to `is_downloading_from`
* refactor: change `isEncrypted` to `is_encrypted`
* refactor: change `isIncoming` to `is_incoming`
* refactor: change `isUploadingTo` to `is_uploading_to`
* refactor: change `isUTP` to `is_utp`
* refactor: change `peerIsChoked` to `peer_is_choked`
* refactor: change `peerIsInterested` to `peer_is_interested`
* refactor: change `rateToClient` to `rate_to_client`
* refactor: change `rateToPeer` to `rate_to_peer`
* refactor: change `fromCache` to `from_cache`
* refactor: change `fromDht` to `from_dht`
* refactor: change `fromIncoming` to `from_incoming`
* refactor: change `fromLpd` to `from_lpd`
* refactor: change `fromLtep` to `from_ltep`
* refactor: change `fromPex` to `from_pex`
* refactor: change `fromTracker` to `from_tracker`
* refactor: change `announceState` to `announce_state`
* refactor: change `downloadCount` to `download_count`
* refactor: change `hasAnnounced` to `has_announced`
* refactor: change `hasScraped` to `has_scraped`
* refactor: change `isBackup` to `is_backup`
* refactor: change `lastAnnouncePeerCount` to `last_announce_peer_count`
* refactor: change `lastAnnounceResult` to `last_announce_result`
* refactor: change `lastAnnounceStartTime` to `last_announce_start_time`
* refactor: change `lastAnnounceSucceeded` to `last_announce_succeeded`
* refactor: change `lastAnnounceTime` to `last_announce_time`
* refactor: change `lastAnnounceTimedOut` to `last_announce_timed_out`
* refactor: change `lastScrapeResult` to `last_scrape_result`
* refactor: change `lastScrapeStartTime` to `last_scrape_start_time`
* refactor: change `lastScrapeSucceeded` to `last_scrape_succeeded`
* refactor: change `lastScrapeTime` to `last_scrape_time`
* refactor: change `lastScrapeTimedOut` to `last_scrape_timed_out`
* refactor: change `leecherCount` to `leecher_count`
* refactor: change `nextAnnounceTime` to `next_announce_time`
* refactor: change `nextScrapeTime` to `next_scrape_time`
* refactor: change `scrapeState` to `scrape_state`
* refactor: change `seederCount` to `seeder_count`
* refactor: change `torrent-added` to `torrent_added`
* refactor: change `torrent-duplicate` to `torrent_duplicate`
* refactor: change `torrent-remove` to `torrent_remove`
* refactor: change `delete-local-data` to `delete_local_data`
* refactor: change `torrent-rename-path` to `torrent_rename_path`
* refactor: change `alt-speed-down` to `alt_speed_down`
* refactor: convert `pref_toggle_entries` to quark array
* refactor: change `alt-speed-enabled` to `alt_speed_enabled`
* refactor: change `compact-view` to `compact_view`
* refactor: change `sort-reversed` to `sort_reversed`
* refactor: change `show-filterbar` to `show_filterbar`
* refactor: change `show-statusbar` to `show_statusbar`
* refactor: change `show-toolbar` to `show_toolbar`
* refactor: change `alt-speed-time-begin` to `alt_speed_time_begin`
* refactor: change `alt-speed-time-day` to `alt_speed_time_day`
* refactor: change `alt-speed-time-end` to `alt_speed_time_end`
* refactor: change `alt-speed-up` to `alt_speed_up`
* refactor: change `alt-speed-time-enabled` to `alt_speed_time_enabled`
* refactor: change `blocklist-enabled` to `blocklist_enabled`
* refactor: change `blocklist-size` to `blocklist_size`
* refactor: change `blocklist-url` to `blocklist_url`
* refactor: change `cache-size-mb` to `cache_size_mb`
* refactor: change `config-dir` to `config_dir`
* refactor: change `default-trackers` to `default_trackers`
* refactor: change `dht-enabled` to `dht_enabled`
* refactor: change `download-dir-free-space` to `download_dir_free_space`
* refactor: change `download-queue-enabled` to `download_queue_enabled`
* refactor: change `download-queue-size` to `download_queue_size`
* refactor: change `idle-seeding-limit-enabled` to `idle_seeding_limit_enabled`
* refactor: change `idle-seeding-limit` to `idle_seeding_limit`
* refactor: change `incomplete-dir-enabled` to `incomplete_dir_enabled`
* refactor: change `incomplete-dir` to `incomplete_dir`
* refactor: change `lpd-enabled` to `lpd_enabled`
* refactor: change `peer-limit-global` to `peer_limit_global`
* refactor: change `peer-limit-per-torrent` to `peer_limit_per_torrent`
* refactor: change `peer-port-random-on-start` to `peer_port_random_on_start`
* refactor: change `peer-port` to `peer_port`
* refactor: change `pex-enabled` to `pex_enabled`
* refactor: change `port-forwarding-enabled` to `port_forwarding_enabled`
* refactor: change `queue-stalled-enabled` to `queue_stalled_enabled`
* refactor: change `queue-stalled-minutes` to `queue_stalled_minutes`
* refactor: change `rename-partial-files` to `rename_partial_files`
* refactor: change `rpc-version-minimum` to `rpc_version_minimum`
* refactor: change `rpc-version-semver` to `rpc_version_semver`
* refactor: change `rpc-version` to `rpc_version`
* refactor: change `script-torrent-added-enabled` to `script_torrent_added_enabled`
* refactor: change `script-torrent-added-filename` to `script_torrent_added_filename`
* refactor: change `script-torrent-done-enabled` to `script_torrent_done_enabled`
* refactor: change `script-torrent-done-filename` to `script_torrent_done_filename`
* refactor: change `script-torrent-done-seeding-enabled` to `script_torrent_done_seeding_enabled`
* refactor: change `script-torrent-done-seeding-filename` to `script_torrent_done_seeding_filename`
* refactor: change `seed-queue-enabled` to `seed_queue_enabled`
* refactor: change `seed-queue-size` to `seed_queue_size`
* refactor: change `seedRatioLimited` to `seed_ratio_limited`
* refactor: change `session-id` to `session_id`
* refactor: change `speed-limit-down-enabled` to `speed_limit_down_enabled`
* refactor: change `speed-limit-down` to `speed_limit_down`
* refactor: change `speed-limit-up-enabled` to `speed_limit_up_enabled`
* refactor: change `speed-limit-up` to `speed_limit_up`
* refactor: change `start-added-torrents` to `start_added_torrents`
* refactor: change `trash-original-torrent-files` to `trash_original_torrent_files`
* refactor: change `utp-enabled` to `utp_enabled`
* refactor: change `tcp-enabled` to `tcp_enabled`
* docs: add missing docs for RPC `tcp_enabled`
* refactor: change `speed-units` to `speed_units`
* refactor: change `speed-bytes` to `speed_bytes`
* refactor: change `size-units` to `size_units`
* refactor: change `size-bytes` to `size_bytes`
* refactor: change `memory-units` to `memory_units`
* refactor: change `memory-bytes` to `memory_bytes`
* refactor: change `session-set` to `session_set`
* refactor: change `session-get` to `session_get`
* refactor: change `session-stats` to `session_stats`
* refactor: change `activeTorrentCount` to `active_torrent_count`
* refactor: change `downloadSpeed` to `download_speed`
* refactor: change `pausedTorrentCount` to `paused_torrent_count`
* refactor: change `torrentCount` to `torrent_count`
* refactor: change `uploadSpeed` to `upload_speed`
* refactor: change `cumulative-stats` to `cumulative_stats`
* refactor: change `current-stats` to `current_stats`
* refactor: change `uploadedBytes` and `uploaded-bytes` to `uploaded_bytes`
* refactor: change `downloadedBytes` and `downloaded-bytes` to `downloaded_bytes`
* refactor: change `filesAdded` and `files-added` to `files_added`
* refactor: change `sessionCount` and `session-count` to `session_count`
* refactor: change `secondsActive` and `seconds-active` to `seconds_active`
* refactor: change `blocklist-update` to `blocklist_update`
* refactor: change `port-test` to `port_test`
* refactor: change `session-close` to `session_close`
* refactor: change `queue-move-top` to `queue_move_top`
* refactor: change `queue-move-up` to `queue_move_up`
* refactor: change `queue-move-down` to `queue_move_down`
* refactor: change `queue-move-bottom` to `queue_move_bottom`
* refactor: change `free-space` to `free_space`
* refactor: change `group-set` to `group_set`
* refactor: change `group-get` to `group_get`
* refactor: change `announce-ip` to `announce_ip`
* refactor: change `announce-ip-enabled` to `announce_ip_enabled`
* refactor: change `upload-slots-per-torrent` to `upload_slots_per_torrent`
* refactor: change `trash-can-enabled` to `trash_can_enabled`
* refactor: change `watch-dir-enabled` to `watch_dir_enabled`
* refactor: change `watch-dir-force-generic` to `watch_dir_force_generic`
* refactor: change `watch-dir` to `watch_dir`
* refactor: change `message-level` to `message_level`
* refactor: change `scrape-paused-torrents-enabled` to `scrape_paused_torrents_enabled`
* refactor: change `torrent-added-verify-mode` to `torrent_added_verify_mode`
* refactor: change `sleep-per-seconds-during-verify` to `sleep_per_seconds_during_verify`
* refactor: change `bind-address-ipv4` to `bind_address_ipv4`
* refactor: change `bind-address-ipv6` to `bind_address_ipv6`
* refactor: change `peer-congestion-algorithm` to `peer_congestion_algorithm`
* refactor: change `peer-socket-tos` to `peer_socket_tos`
* refactor: change `peer-port-random-high` to `peer_port_random_high`
* refactor: change `peer-port-random-low` to `peer_port_random_low`
* refactor: change `anti-brute-force-enabled` to `anti_brute_force_enabled`
* refactor: change `rpc-authentication-required` to `rpc_authentication_required`
* refactor: change `rpc-bind-address` to `rpc_bind_address`
* refactor: change `rpc-enabled` to `rpc_enabled`
* refactor: change `rpc-host-whitelist` to `rpc_host_whitelist`
* refactor: change `rpc-host-whitelist-enabled` to `rpc_host_whitelist_enabled`
* refactor: change `rpc-password` to `rpc_password`
* refactor: change `rpc-port` to `rpc_port`
* refactor: change `rpc-socket-mode` to `rpc_socket_mode`
* refactor: change `rpc-url` to `rpc_url`
* refactor: change `rpc-username` to `rpc_username`
* refactor: change `rpc-whitelist` to `rpc_whitelist`
* refactor: change `rpc-whitelist-enabled` to `rpc_whitelist_enabled`
* refactor: change `ratio-limit-enabled` to `ratio_limit_enabled`
* refactor: change `ratio-limit` to `ratio_limit`
* refactor: change `show-options-window` to `show_options_window`
* refactor: change `open-dialog-dir` to `open_dialog_dir`
* refactor: change `inhibit-desktop-hibernation` to `inhibit_desktop_hibernation`
* refactor: change `show-notification-area-icon` to `show_notification_area_icon`
* refactor: change `start-minimized` to `start_minimized`
* refactor: change `torrent-added-notification-enabled` to `torrent_added_notification_enabled`
* refactor: change `anti-brute-force-threshold` to `anti_brute_force_threshold`
* refactor: change `torrent-complete-notification-enabled` to `torrent_complete_notification_enabled`
* refactor: change `prompt-before-exit` to `prompt_before_exit`
* refactor: change `sort-mode` to `sort_mode`
* refactor: change `statusbar-stats` to `statusbar_stats`
* refactor: change `show-extra-peer-details` to `show_extra_peer_details`
* refactor: change `show-backup-trackers` to `show_backup_trackers`
* refactor: change `blocklist-date` to `blocklist_date`
* refactor: change `blocklist-updates-enabled` to `blocklist_updates_enabled`
* refactor: change `main-window-layout-order` to `main_window_layout_order`
* refactor: change `main-window-height` to `main_window_height`
* refactor: change `main-window-width` to `main_window_width`
* refactor: change `main-window-x` to `main_window_x`
* refactor: change `main-window-y` to `main_window_y`
* refactor: change `filter-mode` to `filter_mode`
* refactor: change `filter-trackers` to `filter_trackers`
* refactor: change `filter-text` to `filter_text`
* refactor: change `remote-session-enabled` to `remote_session_enabled`
* refactor: change `remote-session-host` to `remote_session_host`
* refactor: change `remote-session-https` to `remote_session_https`
* refactor: change `remote-session-password` to `remote_session_password`
* refactor: change `remote-session-port` to `remote_session_port`
* refactor: change `remote-session-requres-authentication` to `remote_session_requires_authentication`
* refactor: change `remote-session-username` to `remote_session_username`
* refactor: change `torrent-complete-sound-command` to `torrent_complete_sound_command`
* refactor: change `torrent-complete-sound-enabled` to `torrent_complete_sound_enabled`
* refactor: change `user-has-given-informed-consent` to `user_has_given_informed_consent`
* refactor: change `read-clipboard` to `read_clipboard`
* refactor: change `details-window-height` to `details_window_height`
* refactor: change `details-window-width` to `details_window_width`
* refactor: change `main-window-is-maximized` to `main_window_is_maximized`
* refactor: change `port-is-open` to `port_is_open`
* refactor: change `show-tracker-scrapes` to `show_tracker_scrapes`
* refactor: change `max-peers` to `max_peers`
* refactor: change `peers2-6` to `peers2_6`
* refactor: change `seeding-time-seconds` to `seeding_time_seconds`
* refactor: change `downloading-time-seconds` to `downloading_time_seconds`
* refactor: change `ratio-mode` to `ratio_mode`
* refactor: change `idle-limit` to `idle_limit`
* refactor: change `idle-mode` to `idle_mode`
* refactor: change `speed-Bps` to `speed_Bps`
* refactor: change `use-global-speed-limit` to `use_global_speed_limit`
* refactor: change `use-speed-limit` to `use_speed_limit`
* chore: remove TODO comment
* docs: add upgrade instructions to `5.0.0`
* chore: bump rpc semver major version
* chore: housekeeping
2025-12-01 16:08:18 -06:00
github-actions[bot]
030b22f91c
chore: update generated transmission-web files ( #7860 )
2025-11-30 11:50:48 -06:00
Charles Kerr
bfa1950fbe
feat: native icons in Qt client ( #7819 )
...
* chore: savepoint
* chore: code style
* refactor: add std::string_view constructor for NativeIcon::Spec
* chore: add TODO comment
* feat: honor per-desktop HIG on when to show menu icons
* chore: remove Faenza system-run icon
unused since b58e95910b
* chore: remove Faenza view-refresh icon
not needed due to b58e95910b
* chore: remove Faenza media-playback-pause icon
not needed due to b58e95910b
* chore: remove Faenza media-playback-start icon
not needed due to b58e95910b
* chore: add a safeguard against merging with incomplete TODO items
* feat: add more icons
refactor: remove some tracer cerr statements
* refactor: remove IconCache use from MainWindow
* chore: remove Faenza icon set
* chore: re-enable remote session network icon
* fix: FTBFS on Windows
* refactor: use symbolic names for Segoe icons
* docs: add links to Segoe MDL2 Assets icon list
* chore: savepoint
segoe icons work
still a WIP; includes test code that should not ship
* feat: use segoe::FastForward for action_StartNow
feat: use segoe::Move for action_SetLocation
refactor: make it easier for devs to force a font at compile time for development work
segoe license does not allow bundling but does allow dev work
chore: code_style.sh
* refactor: remove unused addEmblem()
* docs: add code comment on how to force an icon font
* fix: Win 10, 11 icons play nicely with dark mode
* chore: savepoint
add draft of SF Symbol -> QPixmap loader
* chore: remove dangling font reference from qrc file
* fix: FTBFS
* refactor: use bribri code for NSImage -> QPixmap
* feat: support dark, light mode when rendering SF Symbol monochrome icons
* fixup! feat: support dark, light mode when rendering SF Symbol monochrome icons
fix: fail gracefully on macOS 11
* chore: code style
* chore: tweak some SF Symbol icon choices
* chore: consistent uppercase for hex segoe QChars
* chore: undefine DEV_FORCE_FONT_FAMILY and DEV_FORCE_FONT_RESOURCE
* chore: savepoint
* refactor: clean up NativeIcon impl
* refactor: remove unused MenuMode::Other
* refactor: DRY in FilterBar::createActivityCombo()
* chore: remove obsolete code comment
* refactor: rename icons::Facet as icons::Type
* fix: oops
* refactor: minor cleanup
* fix: tyop
* chore: remove unused #includes
* fix: add modes for some icons
* refactor: tweak some icon choices on macOS
* fix: ensure icons are visible on File, Help menus
fix: remove unused local variable
* refactor: tweak some icon choices for XDG
* refactor: remove the fallback QStyle::StandardPixmaps
These interfere with deciding whether an icon is well-defined and
unambiguous as per the macOS and Windows HIG guidelines.
If a standard or unambiguous icon exists in the native icon sets,
specify it with an SF Symbols name, a Segoe codepoint,
or XDG standard icon name. Otherwise, leave those fields blank.
* refactor: remove unused #includes
* docs: add "choosing icons" section in NativeIcons.cc
* refactor: simplify icons::shouldBeShownInMenu()
* refactor: reduce unnecessary code shear from main
* refactor: make TorrentDelegate::warning_emblem_ const
* refactor: extract-method MainWindow::updateActionIcons()
* feat: update MainWindow icons when light/dark theme changes
* feat: restore the QStyle::StandardPixmaps as fallbacks
Can be used on older Windows / macOS if Segoe or SF Symbols are unavailable
* refactor: add button text for add/edit/remove tracker buttons
QStyle::StandardPixmap doesn't have good icons for these,
so let's ensure that these buttons have visible text.
* fix: building NativeIconMac.mm on mac even if not clang
* chore: iwyu in new code
* docs: tweak the "Choosing Icons" comments again
* fix: handle changed QStyles in icons::icon()
do not cache point_sizes set between calls
refactor: const correctness
* fixup! refactor: simplify icons::shouldBeShownInMenu()
refactor: minor code tweak, declare vars in order that they are used
2025-11-30 10:09:20 -06:00
Yat Ho
1cb24a701b
feat: new JSON-RPC 2.0 RPC API ( #7269 )
...
* feat: add enum for JSON-RPC error codes
* feat: new `tr_rpc_request_exec()` overload that accepts string
* feat: add JSON-RPC parse error handling
* feat: add logic for branching to JSON-RPC or legacy API
* feat: error codes for existing errors strings
* refactor: async handlers now take the done cb as parameter
* feat: support non-batch JSON-RPC requests
* feat: support batch JSON-RPC requests
* refactor: move JSON-RPC error codes to header
* test: new tests for JSON-RPC
* refactor(webui): use jsonrpc api
* docs: update docs for jsonrpc
* fix: clang-tidy warning
* perf: avoid copying callback in batch mode
* code review: don't commit to dropping old RPC
* chore: fix shadowed variable warnings
2025-11-30 10:04:40 -06:00
htmltiger
d64a1a5699
feat: Remote session RPC url path change option qt client ( #7561 )
2025-11-26 14:12:10 -06:00
Yat Ho
78dd0242cf
ci: disable fail-fast for new macOS runners ( #7857 )
2025-11-26 11:26:18 -06:00
Dzmitry Neviadomski
5a995aa335
Update macos actions ( #7845 )
...
* ci: move macos-13 actions to macos-14
We have some GitHub Actions which we try to run on the oldest version of
macOS available. That's currently macos-13, but GitHub is deprecating it:
> This is a scheduled macos-13 brownout.
> The macOS-13 based runner images > are being deprecated. For more details,
> see https://github.com/actions/runner-images/issues/13046 .
We last bumped this from macos-12 to macos-13 in 43f5ca8 #7275
* ci: do not specify architectures in macOS CI builds
GitHub has is phasing out su pport for macOS x86_64 runners
* ci: fold the macos-X-from-tarball jobs into a single job
* ci: fold macos-26 and macos-14 jobs into a single job
* Use macos-15-intel runners instead of macos-14 (arm64).
If we test compilation two times, at least do it on different host
archs.
Also macOS 15 supports latest Xcode with macOS 26.1 SDK.
* Make job names more meaningful
* Fix indentation in macos-xcodebuild-universal
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-11-25 16:52:34 -06:00
Charles Kerr
5cc5538df4
fix: the MainWindow::snetwork_timer_ was not being started when changing from a local to remote session ( #7851 )
2025-11-25 16:05:13 -06:00
Yat Ho
78cd01aa96
fix: libb64 submodule branch ( #7855 )
2025-11-25 15:51:27 -06:00
Charles Kerr
3628a1084e
refactor: extract-method MainWindow::addTorrentFromClipboard() ( #7850 )
2025-11-23 18:18:29 -06:00
Dzmitry Neviadomski
aa08c28cb1
Try out xcbeautify and fix missing artifacts ( #7824 )
2025-11-23 17:01:48 -06:00
Yat Ho
c8b3fb41ae
fix: don't bind udp sockets if no OS support ( #7552 )
2025-11-23 16:19:17 -06:00
Yat Ho
444354e413
refactor: store BT peers with std::shared_ptr ( #7837 )
...
* refactor: use weak_from_this()
* refactor: store peers as shared_ptr
2025-11-22 16:14:10 -06:00
Yat Ho
d044ec82b0
perf: short circuit reset_blocks_bitfield() ( #7838 )
...
Co-authored-by: m0xf <m0xf@ya.ru >
2025-11-22 16:13:26 -06:00
reardonia
6a126fb19e
upload_only fixes, check for partial seeds ( #7785 )
...
* upload_only fixes, check for partial seeds
* fixup!
* fixup (code-style)
2025-11-22 16:11:34 -06:00
Yat Ho
25d2ebf8fc
refactor: overhaul tr_address special address checks ( #7818 )
...
* refactor: rewrite is_martian_addr() with tr_address methods
- Fix broken check for IPv4 multicast address in is_martian_address()
* refactor: rewrite is_global_unicast_address()
- Rewrite using new tr_address methods
- Add missing IPv4 loopback check
- Follow RFC 4291 IPv6 global unicast definition
- Fix and update existing tests
* chore: reorganise methods and add comments
* fix: check for teredo and 6to4
* test: tests for new methods
2025-11-21 18:09:38 -06:00
Dzmitry Neviadomski
40e1bd660d
Fix unreachable in tr_make_listen_socket_ipv6only ( #7825 )
2025-11-19 23:55:09 -06:00
Dzmitry Neviadomski
54f0417f42
Simplify "bars" logic in Main Window ( #7840 )
...
* Adopt NSTitlebarAccessoryViewController for filter and status bars
Also remove custom views as separator is drawn with Horizontal Line.
Simplifies maintainance a bit.
* Unembed main content and status bar from NSStackView
Stack is no longer needed, as bars are moved into titlebar.
2025-11-19 21:30:55 -05:00
Mitch Livingston
147da72453
Revised Tahoe icon, including updated favicons, webclip icon, and document icon ( #7836 )
2025-11-19 20:54:18 -05:00
Dzmitry Neviadomski
495e5bde99
Fix missing tooltips for Group rows in Torrent Table View ( #7828 )
2025-11-18 07:16:08 -05:00
Dzmitry Neviadomski
821e70d742
Add missing protocols to fix deprecation warnings ( #7826 )
2025-11-18 07:13:59 -05:00
Dzmitry Neviadomski
84cc06c651
Apply Xcode 26.0 recommendations ( #7823 )
...
Also sets compatibilityVersion to Xcode 12.0.
Now 'natively' supports BuildIndependentTargetsInParallel option.
No more pain with this line being removed every time Xcode project
touched.
2025-11-17 21:07:55 -05:00
Dzmitry Neviadomski
4d8a1e5e78
Adapt to Liquid Glass window corner metrics ( #7829 )
2025-11-17 19:50:18 -05:00
Dzmitry Neviadomski
aa22aea392
Fix layout constraints in Add Torrent Window ( #7830 )
2025-11-17 19:49:27 -05:00
Charles Kerr
6a7ad3ff09
chore: remove action_ReverseSortOrder icon ( #7815 )
2025-11-14 16:14:38 -06:00
Charles Kerr
fe5a3fb67c
chore: remove edit-clear icon ( #7814 )
...
unused since 03034b5015
2025-11-14 13:50:45 -06:00
Charles Kerr
73e6892a74
refactor: let client pass in translated string of None when calling tr_strratio() ( #7805 )
2025-11-14 10:04:04 -06:00
Yat Ho
cfd5647c58
feat(remote): print seq download from piece in tor details ( #7808 )
2025-11-14 10:02:13 -06:00