Commit Graph

647 Commits

Author SHA1 Message Date
Arnold Schwaighofer
d51053b003 Add convert_escape_to_noescape instruction for converting escaping to noescape functions
@noescape function types will eventually be trivial. A
convert_escape_to_noescape instruction does not take ownership of its
operand. It is a projection to the trivial value carried by the closure
-- both context and implementation function viewed as a trivial value.

A safe SIL program must ensure that the object that the project value is based
on is live beyond the last use of the trivial value. This will be
achieve by means of making the lifetimes dependent.

For example:

  %e = partial_apply [callee_guaranteed] %f(%z) : $@convention(thin) (Builtin.Int64) -> ()
  %n = convert_escape_to_noescape %e : $@callee_guaranteed () -> () to $@noescape @callee_guaranteed () -> ()
  %n2 = mark_dependence %n : $@noescape @callee_guaranteed () -> () on %e : $@callee_guaranteed () -> ()
  %f2 = function_ref @use : $@convention(thin) (@noescape @callee_guaranteed () -> ()) -> ()
  apply %f2(%n2) : $@convention(thin) (@noescape @callee_guaranteed () -> ()) -> ()
  release_value %e : $@callee_guaranteed () -> ()

Note: This is not yet actually used.

Part of:
SR-5441
rdar://36116691
2018-02-06 18:01:23 -08:00
Mark Lacey
b4b66bc8e8 Replace getAnyOptionalObjectType with getOptionalObjectType. 2018-02-05 23:59:00 -08:00
Saleem Abdulrasool
a134cdb2a3 SIL: use unsigned for the member for bool
Use `unsigned` instead of `bool` for the member to make all members of
the structure the same.  This fixes the behaviour of the structure on
Windows.  The difference in the type caused the bitfields to be pushed
to the natural alignment of int resulting in the structure being padded
to 12-bytes instead of being packed into 4.  Using `#pragma pack` also
did not make a difference here as the structure remained padded to
12-bytes.
2018-01-31 18:56:55 -08:00
Chris Lattner
415cd50ba2 Reduce array abstraction on apple platforms dealing with literals (#13665)
* Reduce array abstraction on apple platforms dealing with literals

Part of the ongoing quest to reduce swift array literal abstraction
penalties: make the SIL optimizer able to eliminate bridging overhead
 when dealing with array literals.

Introduce a new classify_bridge_object SIL instruction to handle the
logic of extracting platform specific bits from a Builtin.BridgeObject
value that indicate whether it contains a ObjC tagged pointer object,
or a normal ObjC object. This allows the SIL optimizer to eliminate
these, which allows constant folding a ton of code. On the example
added to test/SILOptimizer/static_arrays.swift, this results in 4x
less SIL code, and also leads to a lot more commonality between linux
and apple platform codegen when passing an array literal.

This also introduces a couple of SIL combines for patterns that occur
in the array literal passing case.
2018-01-02 15:23:48 -08:00
Chris Lattner
de289752fe Implement a few silcombine transformations for arrays (#13652)
* Implement a few silcombine transformations for arrays

 - Useless existential_ref <-> class conversions.
 - mark_dependence_inst depending on uninteresting instructions.
 - release(init_existential_ref(x)) -> release(x) when hasOneUse(x)
 - Update COWArrayOpt to handle the new forms generated by this.

these aren't massive performance wins, but do shrink the size of SIL when
dealing with arrays.

* Generalize testcase to work on linux and on mac when checking stdlib is enabled.
2017-12-30 22:30:37 -08:00
David Zarzycki
679538b72c [SIL] NFC: Migrate SelectInstBase subclasses to InstructionBaseWithTrailingOperands 2017-12-27 11:14:17 -05:00
David Zarzycki
d532fdefe0 [SIL] NFC: Migrate AllocRefInstBase subclasses to InstructionBaseWithTrailingOperands 2017-12-27 08:00:20 -05:00
David Zarzycki
26a1187a3a [SIL] NFC: Migrate CondBranchInst to InstructionBaseWithTrailingOperands
Also, repack misc bits and stop hard coding the number of fixed operands.
2017-12-26 07:39:59 -05:00
David Zarzycki
32284f1023 [SIL] NFC: Migrate ObjectInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
9f42304dd7 [SIL] NFC: Migrate MarkFunctionEscapeInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
81c29d7f98 [SIL] NFC: Migrate SwitchValueInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
bc31a3542f [SIL] NFC: Migrate YieldInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
25b85596b2 [SIL] NFC: Migrate BranchInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
2dc1917283 [SIL] NFC: Migrate AllocBoxInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
2630944535 [SIL] NFC: Migrate AllocExistentialBoxInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
f572569fb1 [SIL] NFC: Migrate BuiltinInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
33300640ae [SIL] NFC: Migrate BindMemoryInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
d2552969f6 [SIL] NFC: Migrate StructInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
65a31cf113 [SIL] NFC: Migrate TupleInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:59 -05:00
David Zarzycki
1321eceb0c [SIL] NFC: Migrate MetatypeInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:58 -05:00
David Zarzycki
ee0550ecdf [SIL] NFC: Migrate WitnessMethodInst to InstructionBaseWithTrailingOperands 2017-12-26 07:39:58 -05:00
David Zarzycki
09d541f758 [SIL] NFC: Refactor UnaryInstructionWithTypeDependentOperandsBase
Refactor UnaryInstructionWithTypeDependentOperandsBase into two template
classes, where the original template now subclasses a simpler template
called "InstructionBaseWithTrailingObjects".
2017-12-26 07:39:58 -05:00
David Zarzycki
ed85954275 [SIL] NFC: Migrate TupleInst to llvm::TrailingObjects
Also, repack the count variable into the misc object header bits.
2017-12-22 11:33:47 -05:00
David Zarzycki
83c1054034 [SIL] NFC: Migrate StructInst to llvm::TrailingObjects
Also, repack the count variable into the misc object header bits.
2017-12-22 11:16:33 -05:00
David Zarzycki
5012a80e39 [SIL] NFC: Repack misc StringLiteralInst bits 2017-12-22 10:58:21 -05:00
David Zarzycki
fcfdd4c8ca [SIL] NFC: Migrate BuiltinInst to llvm::TrailingObjects
Also, repack the count variables into the misc object header bits.
2017-12-22 10:29:41 -05:00
John McCall
94116347a2 Fix some warnings: extra semicolons, anonymous structs. 2017-12-18 15:31:47 -05:00
David Zarzycki
c75e8299f1 [SIL] NFC: Repack misc MetatypeInst bits 2017-12-17 21:35:27 -05:00
David Zarzycki
bc44e5a150 [SIL] NFC: Repack misc BeginAccessInst bits 2017-12-17 21:23:37 -05:00
David Zarzycki
931ea24f99 [SIL] NFC: Repack misc EndAccessInst bits 2017-12-17 21:14:49 -05:00
David Zarzycki
1cd19eae36 [SIL] NFC: Repack misc PointerToAddressInst bits 2017-12-17 20:58:45 -05:00
David Zarzycki
315cf677dd [SIL] NFC: Repack misc SwitchValueInst bits 2017-12-17 20:54:01 -05:00
David Zarzycki
5443923a0c [SIL] NFC: Repack misc SwitchEnumInstBase bits 2017-12-17 20:24:14 -05:00
David Zarzycki
f0bd535261 [SIL] NFC: Repack misc TupleElementAddrInst bits 2017-12-17 19:58:24 -05:00
David Zarzycki
cf443ecfcf [SIL] NFC: Repack misc TupleExtractInst bits 2017-12-17 19:55:17 -05:00
David Zarzycki
b885daf032 [SIL] NFC: Repack misc WitnessMethodInst bits 2017-12-17 19:49:37 -05:00
David Zarzycki
224b8495bc [SIL] NFC: Repack misc DeallocRefInst bits 2017-12-16 19:26:40 -05:00
David Zarzycki
83546faec8 [SIL] NFC: Repack misc IntegerLiteralInst and FloatLiteralInst bits 2017-12-16 19:12:01 -05:00
David Zarzycki
aef2e8c662 [SIL] NFC: Repack misc LoadInst bits 2017-12-16 18:53:08 -05:00
David Zarzycki
c4e90d6e4f [SIL] NFC: Repack misc StoreInst bits 2017-12-16 18:41:14 -05:00
David Zarzycki
c8a458ed1d [SIL] NFC: Repack misc CopyAddrInst bits 2017-12-16 18:31:46 -05:00
David Zarzycki
b5424c0c17 [SIL] NFC: Repack misc StrongPinInst bits 2017-12-16 18:22:52 -05:00
David Zarzycki
edcb0114c4 [SIL] NFC: Repack misc LoadReferenceInstBase bits 2017-12-16 18:04:49 -05:00
David Zarzycki
f6957eade8 [SIL] NFC: Repack misc StoreReferenceInstBase bits 2017-12-16 18:00:08 -05:00
David Zarzycki
a0a5ca5f14 [SIL] NFC: Repack misc RefCountingInst bits 2017-12-16 17:43:31 -05:00
David Zarzycki
7740d4d05d [SIL] NFC: Repack misc UncheckedOwnershipConversionInst bits 2017-12-16 17:35:27 -05:00
David Zarzycki
c68d481d28 [SIL] NFC: Repack misc UnaryInstructionWithTypeDependentOperandsBase bits 2017-12-16 17:05:00 -05:00
David Zarzycki
f0d0c18be6 [SIL] NFC: Repack misc AllocRefInstBase bits 2017-12-16 11:53:29 -05:00
David Zarzycki
d197894a9d [SIL] NFC: Repack misc AllocStackInst bits 2017-12-16 11:38:43 -05:00
David Zarzycki
54ea315586 [Basic] NFC: Stop using transparent unions 2017-12-16 10:43:49 -05:00