Commit Graph

102436 Commits

Author SHA1 Message Date
Saleem Abdulrasool
40e91a8528 test: loosen the overly-restrictive test
The types may be emitted in a different order.  Be more permissive about
ordering.
2020-02-27 20:55:33 -08:00
Andrew Trick
631555aa01 Merge pull request #29738 from zoecarver/ossa/let-prop-opt
[ownership] update let properties opts to support ossa
2020-02-27 18:32:02 -08:00
Daniel Duan
62e0da9913 [Property wrappers] Modernize self enclosing test (#30103)
The init parameter name changed to `wrappedValue` as of Swift 5.2.
2020-02-27 16:05:36 -08:00
AG
93d700001a Merge pull request #29874 from bitjammer/acgarland/rdar-58339492-sg-source-locations
SymbolGraph: Serialize source locations and doc comment ranges
2020-02-27 15:35:57 -08:00
swift-ci
6b1af597fe Merge pull request #30104 from gottesmm/pr-cc29e3d175061f19a6d6a201fa78c513d626a498 2020-02-27 15:07:31 -08:00
Suyash Srijan
a5241edae9 [MiscDiagnostics] Suppress KVO warning when the property has an explicit setter (#30098) 2020-02-27 22:41:50 +00:00
Arnold Schwaighofer
5af921a7cc Merge pull request #30081 from aschwaighofer/irgen_fix_test_class_isa_pointers_armv7k_watchos
Fix irgen test class_isa_pointers_armv7k_watchos.sil
2020-02-27 14:31:02 -08:00
Michael Gottesman
a45c51e509 [semantic-arc-opts] Add a llvm option to enable verification after each individual peephole for compiler writers.
Just useful for quick triaging.
2020-02-27 13:23:36 -08:00
Varun Gandhi
2dfd5694fa [NFC] Don't crash when we see an empty filename for a module. (#30099)
Fixes rdar://problem/59769612.
2020-02-27 12:58:47 -08:00
Arnold Schwaighofer
869e579477 Merge pull request #30076 from aschwaighofer/silgen_fix_dynamic_replacement_before_original
SILGen: Fix dynamic replacement before original function
2020-02-27 12:03:09 -08:00
Nathan Hawes
242e0bb381 Merge pull request #30102 from nathawes/disable-failing-api-digester-test
[test] Disable test/api-digester/stability-stdlib-abi-without-asserts.swift
2020-02-27 11:53:15 -08:00
Nathan Hawes
71e21c476c [test] Disable test/api-digester/stability-stdlib-abi-without-asserts.swift
It's failing CI at the moment:
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator/2871

rdar://problem/59812778
2020-02-27 11:50:55 -08:00
Robert Widmann
0984b1508f Merge pull request #30086 from CodaFi/constexpert-mode
[NFC] Mark The OptionSet API constexpr
2020-02-27 10:16:17 -08:00
Owen Voorhees
78b6759ba4 Merge pull request #30059 from owenv/sourcekit-edu-notes
[Diagnostics][SourceKit] Expose educational notes through SourceKit diagnostics request
2020-02-27 08:12:35 -08:00
Slava Pestov
00318732e1 Merge pull request #30084 from slavapestov/sr-75-prep
More Sema cleanups to prepare for curry thunks
2020-02-27 09:06:38 -05:00
Dmitri Gribenko
910af40940 Merge pull request #29880 from gribozavr/import-cpp-into-swift
Added a document about interoperability between Swift and C++
2020-02-27 14:18:11 +01:00
swift-ci
556866997c Merge pull request #30095 from eeckstein/disable-mangler-verification 2020-02-27 03:05:45 -08:00
Erik Eckstein
4845d81c64 Temporarily disable mangler verification.
I still need to investigate the failures.
To unblock CI I'm disabling the verification for now.

Failing to correctly remangle a symbol should work, but failing so will not cause any severe damage (miscompile, etc.) in most cases.

rdar://problem/59813007
rdar://problem/59496022
https://bugs.swift.org/browse/SR-12204
2020-02-27 10:26:54 +01:00
swift-ci
8e79687c83 Merge pull request #30093 from gottesmm/pr-0273edba71f32c7d89fa25905b403c3bd0b89667 2020-02-26 23:44:25 -08:00
eeckstein
7b2c8f1c87 Merge pull request #30074 from eeckstein/globalopt
GlobalOpt: improvements for constant folding global variables
2020-02-27 08:30:12 +01:00
Pavel Yaskevich
65ab041805 Merge pull request #29868 from omochi/fix-claimNextNamed
[ConstraintSystem] remove unused computation in claimNextNamed
2020-02-26 22:07:42 -08:00
Michael Gottesman
dae0e44d7c [semantic-arc-opts] When eliminating trivially dead insts exposed by eliminating ARC, explicitly mark madeChange true.
Otherwise, on the face of it we do not invalidate analyses as we should. That
being said, I do not think we actually could hit this in practice today since a
trivially dead instruction can only enter the worklist as a result of us
removing some sort of other instruction causing madeChange to be already true.

That being said, I would rather not rely on that in the face of future
change. Found via site reading code.
2020-02-26 22:05:01 -08:00
Brent Royal-Gordon
222c459fb2 [SE-0274] Stage in #filePath (#29944)
* Stage in #filePath

To give users of #file time to transition, we are first adding #filePath without changing #file’s behavior. This commit makes that change.

Fixes <rdar://problem/58586626>.

* Correct swiftinterface test line
2020-02-27 00:03:13 -06:00
Saleem Abdulrasool
10803c0b02 Merge pull request #29807 from compnerd/gottesman-style
build: shuffle `add_swift_target_library` (NFC)
2020-02-26 20:33:18 -08:00
Slava Pestov
9452c60b3b Sema: Remove CSApply's getNaturalArgumentCount() in favor of getNumCurryLevels() 2020-02-26 23:10:07 -05:00
Slava Pestov
90ee606de7 Sema: Refactor CSApply in preparation for curry thunks 2020-02-26 23:10:07 -05:00
Slava Pestov
783ea28f1a AST: Change AutoClosureExpr::isThunk() to getThunkType() 2020-02-26 23:09:54 -05:00
Argyrios Kyrtzidis
b6cafa119c Merge pull request #30090 from akyrtzi/turn-on-fast-completion
[SourceKit] Turn-on by default the fast completion mode
2020-02-26 20:01:21 -08:00
Argyrios Kyrtzidis
4d337f2db2 [SourceKit] Turn-on by default the fast completion mode
rdar://59830963
2020-02-26 18:16:07 -08:00
omochimetaru
79a8a596e4 [ConstraintSystem] remove unused computation in claimNextNamed 2020-02-27 10:49:42 +09:00
Joe Groff
7ac3338384 Merge pull request #30058 from jckarter/dont-cache-fixed-class-metadata
IRGen: Don't cache accesses to fixed class metadata.
2020-02-26 17:21:44 -08:00
Michael Gottesman
b7aaad77e5 Merge pull request #30073 from gottesmm/pr-2049c5667508c622325a30f14e18b0c78bb850bf
[ownership] Move TempRValueOpt before Semantic ARC Opts.
2020-02-26 17:15:19 -08:00
Robert Widmann
581d0076f2 [NFC] Mark The OptionSet API constexpr
All of these bit manipulation primitives have been constexpr-able for
a while now.
2020-02-26 16:59:42 -08:00
Michael Gottesman
71fc5bd347 [opt-tips] Remove -Ounchecked and talk about WMO + 'internal' to reduce dynamic dispatch. (#30068)
* Remove reference to -Ounchecked.

* Add internal + wmo in reducing dynamic dispatch.

* Fix some grammar

Co-Authored-By: Brennan Saeta <brennan.saeta@gmail.com>

Co-authored-by: Brennan Saeta <brennan.saeta@gmail.com>
2020-02-26 16:36:26 -08:00
Xi Ge
e50096fe22 Merge pull request #30080 from nkcsgexi/ObjCCategoryDecl-canonical
ClangImporter: import non-canonical ObjCCategoryDecl after recent clang changes
2020-02-26 15:49:12 -08:00
Michael Gottesman
d1b41e9ac4 [ownership] Add an extra run of TempRValueOpt before Semantic ARC Opts.
There is a natural synergy in between the two passes since TempRValueOpt often
times eliminates temporaries that prevent Semantic ARC Opts from removing ARC
traffic.

NOTE: The reason why I am adding an extra run rather than moving the
TempRValueOpt that runs slightly after SemanticARCOpts on non-ownership SIL is
that the run afterwards is able to run on non-ossa code from the stdlib/etc and
eliminate copies that way. With time once we transition to always serializing in
OSSA form, we will be able to get rid of that second run.
2020-02-26 15:24:07 -08:00
swift-ci
b80b21b656 Merge pull request #30079 from varungandhi-apple/vg-selectively-disable-cross-import-test 2020-02-26 15:13:01 -08:00
Joe Groff
808d33d016 IRGen: Don't cache accesses to fixed class metadata.
The only initialization these class objects need is ObjC realization, which can be done
fast with `objc_opt_self` on recent Apple OSes. The cache check just adds code size and
dirties memory.
2020-02-26 15:10:18 -08:00
Rintaro Ishizaki
c3c5fbc5a2 Merge pull request #30004 from rintaro/ide-completion-genericreq-rdar58580482
[CodeCompletion] Re-implement generic requirement completion
2020-02-26 14:53:00 -08:00
Owen Voorhees
f11df3ee22 [Diagnostics][SourceKit] Expose diagnostic educational notes through SourceKit requests 2020-02-26 14:30:28 -08:00
Arnold Schwaighofer
0c764cb22c Fix irgen test class_isa_pointers_armv7k_watchos.sil
rdar://59818970
2020-02-26 13:46:37 -08:00
Xi Ge
3fe4b89dbf ClangImporter: import non-canonical ObjCCategoryDecl after recent clang changes
Recent clang side change merges ObjCCategoryDecl with the same name. All re-declarations
of a category points to the first category as the canonical one. This patch keeps these
non-canonical redeclarations as separate extensions in Swift.

rdar://problem/59744309
2020-02-26 13:41:09 -08:00
Varun Gandhi
3626f19e76 [NFC] Mark CrossImport test unsupported without assertions. 2020-02-26 13:22:46 -08:00
Saleem Abdulrasool
fc67fc74fb build: shuffle around some functions
This is a purely code motion change.  It moves the functions that are
specific to `SwiftSource.cmake` into `SwiftSource.cmake`.  Target
functions are moved to `stdlib/cmake/modules/AddSwiftStdlib.cmake`.
2020-02-26 12:47:43 -08:00
Joe Groff
0fb4ea1ec3 Merge pull request #30003 from NobodyNada/master
[SILOptimizer] Generalize optimization of static key paths, take 2
2020-02-26 12:13:43 -08:00
Suyash Srijan
d7bba7f193 [Typechecker] Use getCalledValue() rather than using DeclRefExpr to get the function decl when checking ignored expressions (#30077) 2020-02-26 19:49:58 +00:00
Rintaro Ishizaki
fc28f909b8 [CodeCompletion] Tweak canBeUsedAsRequirementFirstType() 2020-02-26 10:58:01 -08:00
Doug Gregor
031f5a4888 Merge pull request #30065 from DougGregor/function-builders-if-case-fixes
[Constraint system] Cleanups for function builders support for if let/if case let
2020-02-26 10:38:15 -08:00
Pavel Yaskevich
e70ef60ad5 Merge pull request #30067 from xedin/rdar-59741308
[ConstraintSystem] Don't attempt bindings for closure parameters/resu…
2020-02-26 10:03:58 -08:00
Rintaro Ishizaki
0dd0092e9e [CodeCompletion] Only suggest generic params in where for non-protocol
nominal types
2020-02-26 09:57:18 -08:00