mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
* Revert "[CSOptimizer] Look through `OptionalEvaluationExpr`s when dealing with unapplied disjunctions" This reverts commit72340f39b8. * Revert "[CSOptimizer] Don't consider disabled overloads when checking whether disjunction is supported" This reverts commit6bc23b5057. * Revert "[CSOptimizer] Disjunctions with IUO overload choices are unsupported" This reverts commit471ee21535. * Revert "[CSOptimizer] MemberImportVisibility: Don't consider overloads that come from implicit imports" This reverts commitaa4a2b9071. * Revert "[CSOptimizer] Don't consider CGFloat widening when explicit initializer is used" This reverts commit3cc76eacdd. * Revert "[CSOptimizer] Literal arguments should cause score reset only for operators" This reverts commite3987beffb. * Revert "[CSOptimizer] NFC: check whether a choice is of operator instead of whole disjunction" This reverts commit6c82892c3c. * Revert "[CSOptimizer/Tests] NFC: Add a perf test-case fixed by improved literal array handling" This reverts commitcfd34e54c4. * Revert "[CSOptimizer] Extend candidate/parameter matching to support array literals" This reverts commit8a304f88c6. * Revert "[CSOptimizer] Favor choices that don't require application" This reverts commit0737542da8. * Revert "[CSOptimizer] Disable CGFloat -> Double conversion for unary operators" This reverts commitbc3a15fbe6. * Revert "[CSOptimizer] Mark bitwise operators as supported" This reverts commit860ae08d1b. * Revert "[CSOptimizer] Simplify handling of non-applied disjunctions" This reverts commit43ca7dfff9. * Revert "[ConstraintSystem] Fix `getEffectiveOverloadType` handling of `mutating` methods" This reverts commitc767f7aff7. * Revert "[CSOptimizer] Reduce overload types before ranking" This reverts commit95b47aead6. * Revert "[CSOptimizer] Implement special prioritization rules for result builder contexts" This reverts commit56d6635e46. * Revert "[CSOptimizer] Allow only widening CGFloat->Double conversions while matching candidate arguments" This reverts commitbf8ae3bc1b. * Revert "[CSSimplify] CGFloat-Double: Rank narrowing correctly when result is injected into an optional" This reverts commitcb876cbd9e. * Revert "[CSBindings] Prevent `BindingSet::isViable` from dropping viable bindings (v2)" This reverts commitb7e7493076. * Revert "[CSOptimizer] Add support for chained members without arguments" This reverts commit87cd5f8733. * Revert "[CSOptimizer] Mark compiler synthesized disjunctions as optimized" This reverts commit867e64182f. * Revert "[CSOptimizer] Make a light-weight generic overload check if some requirements are unsatisfiable" This reverts commit15c773b9d7. * Revert "[CSOptimizer] Fix `selectDisjunction` to use favored choices even if disjunction was not optimized" This reverts commitc2a55886f0. * Revert "[CSOptimizer] Limit "old" behavior compatibility to unlabeled unary arguments" This reverts commit9fb73143f6. * Revert "[Tests] NFC: Update a couple of type-checker tests" This reverts commitff8663ff16. * Revert "[Tests] NFC: Move simd related test-case from `slow` to `fast`" This reverts commit28396a6dce. * Revert "[CSGen] NFC: Remove obsolete `ConstraintSystem::{get, set}FavoredType`" This reverts commit8bd288447f. * Revert "[CSOptimizer] Allow literal arguments to match parameters that conform to `ExpressibleBy{Integer, Float}Literal`" This reverts commit2fdd4b6c35. * Revert "[CSOptimizer] Adjust `scoreCandidateMatch` to indicate when match cannot be decided" This reverts commit9b62c84a4f. * Revert "[CSOptimizer] Fix Double<->CGFloat implicit conversion support when arguments are literals" This reverts commit6caf1ccbb2. * Revert "[CSOptimizer] A more comprehensive generic overload checking when candidates are fully resolved" This reverts commite30587bda4. * Revert "[CSOptimizer] Restore old hack behavior which used to favor overloads based on arity matches" This reverts commita3a3ec4fe0. * Revert "[CSOptimizer] Desugar types before checking for equality" This reverts commit802f5cd105. * Revert "[ConstraintSystem] Narrowly disable `tryOptimizeGenericDisjunction` when some of the arguments are number literals" This reverts commit8d5cb112ef. * Revert "[CSOptimizer] Infer argument candidates from calls to `Double` and CGFloat constructors" This reverts commitf2a6677a6d. * Revert "[CSOptimizer] Score all of the overload choices matching on literals uniformly" This reverts commit59109c2d60. * Revert "[CSOptimizer] Enable ranking of `Int*`, `Float{80}` and `Double` initializers" This reverts commit6fb6d1cf90. * Revert "[CSOptimizer] Rank disjunctions based on score only if both sides are supported" This reverts commit8818d399f9. * Revert "[CSOptimizer] Rank results of operators regardless of whether anything is known about parameters" This reverts commit3996b25fbd. * Revert "[Tests] NFC: Add more test-cases that were previously solved due to old hacks behavior" This reverts commitd0ff6c81b8. * Revert "[CSOptimizer] Average score should reflect number of defaulted parameters" This reverts commit23589add74. * Revert "[Tests] NFC: Adjust a couple of improved tests" This reverts commit66981364fe. * Revert "[CSOptimizer] Don't optimize (implicit) calls with code completion arguments" This reverts commit8a918e2369. * Revert "[CSOptimizer] attempt to rank only standard/simd operators and fully concrete overload sets" This reverts commitdeca9b61c5. * Revert "[CSOptimizer] Record best scores for each disjunction and use them in `selectDisjunction`" This reverts commit3819ddfb40. * Revert "[CSOptimizer] Let `determineBestChoicesInContext` return the best disjunction if one is available" This reverts commitcf05405eae. * Revert "[CSOptimizer] Emulate old behavior related to favoring of unary calls to members" This reverts commit527de22bec. * Revert "[Tests] NFC: Add a test-case for rdar://133340307 which is now fast" This reverts commit670127abd6. * Revert "[CSOptimizer] Prefer homogeneous arithmetic operator overloads when argument(s) or result match" This reverts commitd69b6a0594. * Revert "[CSOptimizer] Remove an outdated optimization to compare resolved argument types with all else equal" This reverts commit1760bd1f1e. * Revert "[CSOptimizer] NFC: Switch from llvm::Optional to std::optional post-rebase" This reverts commitc429f5b9ec. * Revert "[CSOptimizer] Increase score when type matches opaque type" This reverts commit2869dff995. * Revert "[CSOptimizer] NFC: Switch to llvm::Optional" This reverts commit0fc6806922. * Revert "[CSOptimizer] NFC: Adjust conformance check to use `ConstraintSystem::lookupConformance`" This reverts commitda65333d41. * Revert "[CSOptimizer] Treat all type parameters equally" This reverts commit957a5f4270. * Revert "[CSStep] Remove disjunction pruning logic from DisjunctionStep" This reverts commit2c44e37948. * Revert "[CSOptimizer] Relax candidate type requirements from equality to set of no-impact conversions" This reverts commit11b897b32f. * Revert "[CSOptimizer] Use `matchCallArguments` to establish argument-to-parameter relationships" This reverts commitcb1cb2018d. * Revert "[CSOptimizer] Don't attempt to optimize calls with code completion token(s) in argument position" This reverts commit14e2a16fce. * Revert "[CSOptimizer] Allow generic operator overloads without associated type parameters" This reverts commitbc5f70a9a3. * Revert "[CSOptimizer] Make sure that all parameters without arguments are defaulted" This reverts commit7c1c46d4e4. * Revert "[CSStep] Don't favor choices until the disjunction is picked" This reverts commite404ed722a. * Revert "[CSOptimizer] Keep track of mismatches while evaluating candidates" This reverts commita094c3ebb0. * Revert "[CSOptimizer] Favor SIMD related arithmetic operator choices if argument is SIMD<N> type" This reverts commitc2f7451c7b. * Revert "[CSOptimizer] Initial implementation of disjunction choice favoring algorithm" This reverts commit672ae3d252. * Revert "[ConstraintSystem] Add skeleton of constraint optimizer" This reverts commitb5f08a4009. * Revert "[CSGen] Remove ConstraintOptimizer and all favoring logic" This reverts commit4432c51f57. * Revert "[ConstraintSystem] Remove `shrink`" This reverts commit757ca24e8a. * [TypeChecker] NFC: Remove resurrected use of `SolverShrinkUnsolvedThreshold` * [TypeChecker] Bring back `SolverDisableShrink` * [Tests] NFC: Mark tests affected by solver-perf revert as slow * [Tests] NFC: Adjust async tests that are affected by performance hacks
75 lines
5.7 KiB
Swift
75 lines
5.7 KiB
Swift
// RUN: %target-typecheck-verify-swift -enable-objc-interop -swift-version 6
|
|
|
|
func id<T>(_ x: T) -> T { x }
|
|
func ohno<T>(_ x: T) -> T? { nil }
|
|
|
|
// Swift 6 version of the test in casts.swift
|
|
func test_compatibility_coercions(_ arr: [Int], _ optArr: [Int]?, _ dict: [String: Int], _ set: Set<Int>, _ i: Int, _ stringAnyDict: [String: Any]) {
|
|
// These have always been fine.
|
|
_ = arr as [Any]?
|
|
_ = dict as [String: Int]?
|
|
_ = set as Set<Int>
|
|
|
|
// These have always been errors.
|
|
_ = arr as [String] // expected-error {{cannot convert value of type '[Int]' to type '[String]' in coercion}}
|
|
// expected-note@-1 {{arguments to generic parameter 'Element' ('Int' and 'String') are expected to be equal}}
|
|
_ = dict as [String: String] // expected-error {{cannot convert value of type '[String : Int]' to type '[String : String]' in coercion}}
|
|
// expected-note@-1 {{arguments to generic parameter 'Value' ('Int' and 'String') are expected to be equal}}
|
|
_ = dict as [String: String]? // expected-error {{'[String : Int]' is not convertible to '[String : String]?'}}
|
|
// expected-note@-1 {{did you mean to use 'as!' to force downcast?}} {{12-14=as!}}
|
|
_ = (dict as [String: Int]?) as [String: Int] // expected-error {{value of optional type '[String : Int]?' must be unwrapped to a value of type '[String : Int]'}}
|
|
// expected-note@-1 {{coalesce using '??' to provide a default when the optional value contains 'nil'}}
|
|
// expected-note@-2 {{force-unwrap using '!' to abort execution if the optional value contains 'nil'}}
|
|
_ = set as Set<String> // expected-error {{cannot convert value of type 'Set<Int>' to type 'Set<String>' in coercion}}
|
|
// expected-note@-1 {{arguments to generic parameter 'Element' ('Int' and 'String') are expected to be equal}}
|
|
|
|
// Make sure we error on the following in Swift 6 mode.
|
|
_ = id(arr) as [String] // expected-error {{conflicting arguments to generic parameter 'T' ('[Int]' vs. '[String]')}}
|
|
_ = (arr ?? []) as [String] // expected-error {{conflicting arguments to generic parameter 'T' ('[String]' vs. '[Int]')}}
|
|
_ = (arr ?? [] ?? []) as [String] // expected-error {{conflicting arguments to generic parameter 'T' ('[String]' vs. '[Int]')}}
|
|
// expected-error@-1{{conflicting arguments to generic parameter 'T' ('[String]' vs. '[Int]')}}
|
|
_ = (optArr ?? []) as [String] // expected-error {{conflicting arguments to generic parameter 'T' ('[Int]' vs. '[String]'}}
|
|
|
|
_ = (arr ?? []) as [String]? // expected-error {{'[Int]' is not convertible to '[String]?'}}
|
|
// expected-note@-1 {{did you mean to use 'as!' to force downcast?}}
|
|
_ = (arr ?? []) as [String?]? // expected-error {{'[Int]' is not convertible to '[String?]?'}}
|
|
// expected-note@-1 {{did you mean to use 'as!' to force downcast?}}
|
|
_ = (arr ?? []) as [String??]?? // expected-error {{'[Int]' is not convertible to '[String??]??'}}
|
|
// expected-note@-1 {{did you mean to use 'as!' to force downcast?}}
|
|
_ = (dict ?? [:]) as [String: String?]? // expected-error {{'[String : Int]' is not convertible to '[String : String?]?'}}
|
|
// expected-note@-1 {{did you mean to use 'as!' to force downcast?}}
|
|
_ = (set ?? []) as Set<String>?? // expected-error {{'Set<Int>' is not convertible to 'Set<String>??'}}
|
|
// expected-note@-1 {{did you mean to use 'as!' to force downcast?}}
|
|
|
|
_ = ohno(ohno(ohno(arr))) as [String] // expected-error {{cannot convert value of type '[Int]???' to type '[String]' in coercion}}
|
|
_ = ohno(ohno(ohno(arr))) as [Int] // expected-error {{cannot convert value of type '[Int]???' to type '[Int]' in coercion}}
|
|
_ = ohno(ohno(ohno(Set<Int>()))) as Set<String> // expected-error {{cannot convert value of type 'Set<Int>???' to type 'Set<String>' in coercion}}
|
|
_ = ohno(ohno(ohno(["": ""]))) as [Int: String] // expected-error {{cannot convert value of type '[String : String]???' to type '[Int : String]' in coercion}}
|
|
_ = ohno(ohno(ohno(dict))) as [String: Int] // expected-error {{cannot convert value of type '[String : Int]???' to type '[String : Int]' in coercion}}
|
|
|
|
// In this case the array literal can be inferred to be [String], so totally
|
|
// valid.
|
|
_ = ([] ?? []) as [String] // expected-warning {{left side of nil coalescing operator '??' has non-optional type '[String]', so the right side is never used}}
|
|
_ = (([] as Optional) ?? []) as [String]
|
|
|
|
// The array can also be inferred to be [Any].
|
|
_ = ([] ?? []) as Array // expected-warning {{left side of nil coalescing operator '??' has non-optional type '[Any]', so the right side is never used}}
|
|
|
|
// Cases from rdar://88334481
|
|
typealias Magic<T> = T
|
|
_ = [i] as [String] // expected-error {{cannot convert value of type 'Int' to expected element type 'String'}}
|
|
_ = [i] as Magic as [String] // expected-error {{cannot convert value of type 'Int' to expected element type 'String'}}
|
|
_ = ([i]) as Magic as [String] // expected-error {{cannot convert value of type 'Int' to expected element type 'String'}}
|
|
_ = [i: i] as [String: Any] // expected-error {{cannot convert value of type 'Int' to expected dictionary key type 'String'}}
|
|
_ = ([i: i]) as [String: Any] // expected-error {{cannot convert value of type 'Int' to expected dictionary key type 'String'}}
|
|
_ = [i: stringAnyDict] as [String: Any] // expected-error {{cannot convert value of type 'Int' to expected dictionary key type 'String'}}
|
|
|
|
_ = [i].self as Magic as [String] // expected-error {{cannot convert value of type 'Int' to expected element type 'String'}}
|
|
_ = (try [i]) as Magic as [String] // expected-error {{cannot convert value of type 'Int' to expected element type 'String'}}
|
|
// expected-warning@-1 {{no calls to throwing functions occur within 'try' expression}}
|
|
|
|
// These are wrong, but make sure we don't warn about the value cast always succeeding.
|
|
_ = [i: i] as! [String: Any]
|
|
_ = [i: stringAnyDict] as! [String: Any]
|
|
}
|