Michael Gottesman 2914c6b0f5 [di] Once we have exclusively borrowed self, if we go down the non-formal evaluation path, copy instead of asserting. ...

We can only do this for two reasons:

1. There is a code path that should have gone through the non-exclusively
borrowed self entrypoints, but they were not implemented.
2. We are trying to access self for an argument.

By copying the value, we preserve invariants around ownership and also make it
easy for DI to catch 2 and not blow up in the case of 1. It is better to error
in DI incorrectly, than to hit an unreachable (especially since in non-assert
builds, we don't trap at unreachables and just continue to the next function in
the text segment).

SR-5682
rdar://35402738

2017-11-15 21:38:21 -08:00

34 KiB

Raw Blame History

View Raw